Improved GameObjects initialization, fixed the possibility to break GameObjects from outer assemblies, made prediction - related methods overridable in Spell.cs#96
Open
Wiciaki wants to merge 2 commits intoLeagueSharp:masterfrom
Wiciaki:master
Open
Improved GameObjects initialization, fixed the possibility to break GameObjects from outer assemblies, made prediction - related methods overridable in Spell.cs#96Wiciaki wants to merge 2 commits intoLeagueSharp:masterfrom Wiciaki:master
Wiciaki wants to merge 2 commits intoLeagueSharp:masterfrom
Wiciaki:master
Conversation
|
💯 |
|
🔥 |
|
|
||
| // Load GameObjects. | ||
| GameObjects.Initialize(); | ||
| RuntimeHelpers.RunClassConstructor(typeof(GameObjects).TypeHandle); |
Author
There was a problem hiding this comment.
This executes the .cctor if it hasn't already
Contributor
There was a problem hiding this comment.
I'd rather not see any dirty reflection methods to achieve this.
Author
There was a problem hiding this comment.
How it this reflection or a dirty method?
Author
|
There are essentially 2 approaches to expose the lists / public properties in GameObjects
The current IEnumerable approach is bad because it is slower to use and anyone can cast it back to List and do whatever he wants. Just my 2 cents :roto2: |
Contributor
|
Or just implement cache in the core :^) |
|
🍿 |
ghost
assigned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.